On Tuesday 16 October 2007 20:34:17 Gautham R Shenoy wrote:
> This patch implements a Refcount + Waitqueue based model for
> cpu-hotplug.
Hi Gautham,
I can't see where you re-initialize the completion.
> +static void cpu_hotplug_begin(void)
> +{
> + mutex_lock(&cpu_hotplug.lock);
> + cpu_hotplug.active_writer = current;
> + while (cpu_hotplug.refcount) {
> + mutex_unlock(&cpu_hotplug.lock);
> + wait_for_completion(&cpu_hotplug.readers_done);
> + mutex_lock(&cpu_hotplug.lock);
> + }
AFAICT this will busy-wait on the second CPU hotplug.
Cheers,
Rusty.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
