Hi Geert, Thank you for the review.
On Fri, Jun 5, 2020 at 1:27 PM Geert Uytterhoeven <[email protected]> wrote: > > Hi Prabhakar, > > On Wed, May 27, 2020 at 3:29 PM Lad Prabhakar > <[email protected]> wrote: > > Add support for the camera daughter board which is connected to > > iWave's RZ/G1H Qseven carrier board. Also enable ttySC[0135] and > > ethernet1 interfaces. > > > > Signed-off-by: Lad Prabhakar <[email protected]> > > Reviewed-by: Marian-Cristian Rotariu > > <[email protected]> > > Reviewed-by: Geert Uytterhoeven <[email protected]> > > > --- /dev/null > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts > > > +&scifb1 { > > + pinctrl-0 = <&scifb1_pins>; > > + pinctrl-names = "default"; > > + status = "okay"; > > Before I queue this in renesas-devel for v5.9, I have on question: > As this port carries RTS/CTS signals, perhaps you want to add > > rts-gpios = <&gpio4 21 GPIO_ACTIVE_LOW>; > cts-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>; > Aaha the user manual mentioned RTS/CTS wasn't connected, but I tested this with the above which disproves the Doc. Shall I post it as a separate patch or post a v2 including it. Cheers, --Prabhakar > ? > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- > [email protected] > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like > that. > -- Linus Torvalds
