Re: [PATCH v15 01/14] mm/page_ext: Export lookup_page_ext() to GPL modules

[David Hildenbrand]

> Am 08.06.2020 um 18:11 schrieb Christoph Hellwig <h...@infradead.org>:
> 
> On Mon, Jun 08, 2020 at 01:53:23PM +0200, David Hildenbrand wrote:
>>> @@ -131,6 +131,7 @@ struct page_ext *lookup_page_ext(const struct page 
>>> *page)
>>>                    MAX_ORDER_NR_PAGES);
>>>    return get_entry(base, index);
>>> }
>>> +EXPORT_SYMBOL_GPL(lookup_page_ext);
>>> 
>>> static int __init alloc_node_page_ext(int nid)
>>> {
>>> 
>> 
>> I've been told to always smuggle new EXPORTs into the patch that
>> actually needs it (and cc relevant people on that patch instead).
> 
> A separate patch for anything remotely controversial really helps it
> to stick out, so I think keeping it separate is a very good practice.
> 

That used to be my approach until Michal told me to do it differently. And 
there is a good point for it: Reviewers actually understand in which context it 
is used and if it is really required.

Having that said, I don‘t have a strong opinion on this.