On Wed, May 27, 2020 at 6:53 AM Arnd Bergmann <[email protected]> wrote: > > The clang integrated assembler requires the 'cmp' instruction to > have a length prefix here: > > arch/x86/math-emu/wm_sqrt.S:212:2: error: ambiguous instructions require an > explicit suffix (could be 'cmpb', 'cmpw', or 'cmpl') > cmp $0xffffffff,-24(%ebp) > ^ > > Make this a 32-bit comparison, which it was clearly meant to be. > > Signed-off-by: Arnd Bergmann <[email protected]>
Thanks for the patch. Reviewed-by: Nick Desaulniers <[email protected]> > --- > arch/x86/math-emu/wm_sqrt.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/math-emu/wm_sqrt.S b/arch/x86/math-emu/wm_sqrt.S > index 3b2b58164ec1..40526dd85137 100644 > --- a/arch/x86/math-emu/wm_sqrt.S > +++ b/arch/x86/math-emu/wm_sqrt.S > @@ -209,7 +209,7 @@ sqrt_stage_2_finish: > > #ifdef PARANOID > /* It should be possible to get here only if the arg is ffff....ffff */ > - cmp $0xffffffff,FPU_fsqrt_arg_1 > + cmpl $0xffffffff,FPU_fsqrt_arg_1 > jnz sqrt_stage_2_error > #endif /* PARANOID */ > > -- -- Thanks, ~Nick Desaulniers
