From: Wei Yongjun <weiyongj...@huawei.com>

[ Upstream commit 88ec7cb22ddde725ed4ce15991f0bd9dd817fd85 ]

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: b7370112f519 ("lpc32xx: Added ethernet driver")
Signed-off-by: Wei Yongjun <weiyongj...@huawei.com>
Acked-by: Vladimir Zapolskiy <v...@mleia.com>
Signed-off-by: David S. Miller <da...@davemloft.net>
Signed-off-by: Sasha Levin <sas...@kernel.org>
---
 drivers/net/ethernet/nxp/lpc_eth.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/nxp/lpc_eth.c 
b/drivers/net/ethernet/nxp/lpc_eth.c
index 41d30f55c946..6bd6c261f2ba 100644
--- a/drivers/net/ethernet/nxp/lpc_eth.c
+++ b/drivers/net/ethernet/nxp/lpc_eth.c
@@ -845,7 +845,8 @@ static int lpc_mii_init(struct netdata_local *pldat)
        if (mdiobus_register(pldat->mii_bus))
                goto err_out_unregister_bus;
 
-       if (lpc_mii_probe(pldat->ndev) != 0)
+       err = lpc_mii_probe(pldat->ndev);
+       if (err)
                goto err_out_unregister_bus;
 
        return 0;
-- 
2.25.1

Reply via email to