* Kamalesh Babulal <[EMAIL PROTECTED]> wrote:

> While running kernbench with the 2.6.23-git8 following oops is 
> produced

Dmitry found something that might explain the crash: could you check 
whether the patch below fixes it?

        Ingo

---------------------->
Subject: sched: fix new task startup crash
From: Ingo Molnar <[EMAIL PROTECTED]>

this should fix the put_prev_task crashes that were reported,
Dmitry Adamushko noticed that it's not valid to call into
task_new_fair() if this_cpu != task_cpu(p).

Reported-by: Kamalesh Babulal <[EMAIL PROTECTED]>
Reported-by: Andy Whitcroft <[EMAIL PROTECTED]>
Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]>
---
 kernel/sched.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: linux/kernel/sched.c
===================================================================
--- linux.orig/kernel/sched.c
+++ linux/kernel/sched.c
@@ -1712,7 +1712,8 @@ void fastcall wake_up_new_task(struct ta
 
        p->prio = effective_prio(p);
 
-       if (!p->sched_class->task_new || !current->se.on_rq || !rq->cfs.curr) {
+       if (!p->sched_class->task_new || smp_processor_id() != task_cpu(p) ||
+                       !current->se.on_rq || !rq->cfs.curr) {
                activate_task(rq, p, 0);
        } else {
                /*
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to