On 2020/6/10 3:20, Eric W. Biederman wrote:
Xiaoming Ni <[email protected]> writes:Since the commit 61a47c1ad3a4dc ("sysctl: Remove the sysctl system call"), sys_sysctl has lost its actual role: any input can only return an error.The remaining code does have a role. It reports programs that attempt to use the removed sysctl. It would help if your change description had a reason why we don't want to warn people that a program has used a removed system call. Probably something like: We have been warning about people using the sysctl system call for years and believe there are no more users. Even if there are users of this interface if they have not complained or fixed their code by now they probably are not going to, so there is no point in warning them any longer. With a change like that made to the patch description. Acked-by: "Eric W. Biederman" <[email protected]>
Thanks for your guidance I will add it in the v2 version Thanks Xiaoming Ni
