The pllb_arm_lookup pointer in the struct raspberrypi_clk is not used for
anything but to store the returned pointer to clkdev_hw_create, and is not
used anywhere else in the driver.

Let's remove that global pointer from the structure.

Cc: Michael Turquette <mturque...@baylibre.com>
Cc: linux-...@vger.kernel.org
Acked-by: Nicolas Saenz Julienne <nsaenzjulie...@suse.de>
Reviewed-by: Stephen Boyd <sb...@kernel.org>
Signed-off-by: Maxime Ripard <max...@cerno.tech>
---
 drivers/clk/bcm/clk-raspberrypi.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/clk/bcm/clk-raspberrypi.c 
b/drivers/clk/bcm/clk-raspberrypi.c
index d62605861028..5a06c4991c7f 100644
--- a/drivers/clk/bcm/clk-raspberrypi.c
+++ b/drivers/clk/bcm/clk-raspberrypi.c
@@ -40,7 +40,6 @@ struct raspberrypi_clk {
        unsigned long max_rate;
 
        struct clk_hw pllb;
-       struct clk_lookup *pllb_arm_lookup;
 };
 
 /*
@@ -238,6 +237,7 @@ static struct clk_fixed_factor raspberrypi_clk_pllb_arm = {
 
 static int raspberrypi_register_pllb_arm(struct raspberrypi_clk *rpi)
 {
+       struct clk_lookup *pllb_arm_lookup;
        int ret;
 
        ret = devm_clk_hw_register(rpi->dev, &raspberrypi_clk_pllb_arm.hw);
@@ -246,9 +246,9 @@ static int raspberrypi_register_pllb_arm(struct 
raspberrypi_clk *rpi)
                return ret;
        }
 
-       rpi->pllb_arm_lookup = clkdev_hw_create(&raspberrypi_clk_pllb_arm.hw,
-                                               NULL, "cpu0");
-       if (!rpi->pllb_arm_lookup) {
+       pllb_arm_lookup = clkdev_hw_create(&raspberrypi_clk_pllb_arm.hw,
+                                          NULL, "cpu0");
+       if (!pllb_arm_lookup) {
                dev_err(rpi->dev, "Failed to initialize pllb_arm_lookup\n");
                return -ENOMEM;
        }
-- 
git-series 0.9.1

Reply via email to