Am 10.06.20 um 11:04 schrieb Daniel Palmer:
diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index 59fde2d598d8..e7f4ca060c0f 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -197,6 +197,7 @@ machine-$(CONFIG_ARCH_MXC)          += imx
  machine-$(CONFIG_ARCH_MEDIATEK)               += mediatek
  machine-$(CONFIG_ARCH_MILBEAUT)               += milbeaut
  machine-$(CONFIG_ARCH_MXS)            += mxs
+machine-$(CONFIG_ARCH_MSTARV7)         += mstar
  machine-$(CONFIG_ARCH_NOMADIK)                += nomadik
  machine-$(CONFIG_ARCH_NPCM)           += npcm
  machine-$(CONFIG_ARCH_NSPIRE)         += nspire
diff --git a/arch/arm/mach-mstar/Kconfig b/arch/arm/mach-mstar/Kconfig
new file mode 100644
index 000000000000..6235d0a7860a
--- /dev/null
+++ b/arch/arm/mach-mstar/Kconfig
@@ -0,0 +1,26 @@
+menuconfig ARCH_MSTARV7

You call the dir mach-mstar, but name the Kconfig ARCH_MSTARV7. I had previously been asked to just use the vendor name, so this should probably be just ARCH_MSTAR. Outside arch/arm/ you can then use ARM && ARCH_MSTAR condition to make things 32-bit only, allowing to reuse ARCH_MSTAR for arm64 or whatever.

+       bool "MStar/Sigmastar ARMv7 SoC Support"
+       depends on ARCH_MULTI_V7
+       select ARM_GIC
+       select ARM_HEAVY_MB
+       help
+         Support for newer MStar/Sigmastar SoC families that are
+         based on ARMv7 cores like the Cortex A7 and share the same
+         basic hardware like the infinity and mercury series.
+
+if ARCH_MSTARV7
+
+config MACH_INFINITY
+       bool "MStar/Sigmastar infinity SoC support"
+       default ARCH_MSTARV7
+       help
+         Support for MStar/Sigmastar infinity IP camera SoCs.
+
+config MACH_MERCURY
+       bool "MStar/Sigmastar mercury SoC support"
+       default ARCH_MSTARV7
+       help
+         Support for MStar/Sigmastar mercury dash camera SoCs.
+         Note that older Mercury2 SoCs are ARM9 based and not supported.

Is this comment really helpful? This menu item would only seem to come up after having selected multi_v7, which kind of rules out ARM9.

Consider adding mercury in a second step?

+
+endif

Regards,
Andreas

--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)

Reply via email to