Hi Kaaira,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on next-20200612]
[cannot apply to v5.7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    
https://github.com/0day-ci/linux/commits/Kaaira-Gupta/vimc-Add-colors-order-over-test-image/20200613-015755
base:   git://linuxtv.org/media_tree.git master
config: riscv-allyesconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross 
ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

drivers/media/common/v4l2-tpg/v4l2-tpg-core.c: In function 'tpg_g_color_order':
>> drivers/media/common/v4l2-tpg/v4l2-tpg-core.c:2027:3: warning: 'return' with 
>> no value, in function returning non-void [-Wreturn-type]
2027 |   return;
|   ^~~~~~
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c:2009:13: note: declared here
2009 | const char *tpg_g_color_order(const struct tpg_data *tpg)
|             ^~~~~~~~~~~~~~~~~

vim +/return +2027 drivers/media/common/v4l2-tpg/v4l2-tpg-core.c

  2008  
  2009  const char *tpg_g_color_order(const struct tpg_data *tpg)
  2010  {
  2011          switch (tpg->pattern) {
  2012          case (TPG_PAT_75_COLORBAR || TPG_PAT_100_COLORBAR || 
TPG_PAT_CSC_COLORBAR):
  2013                  return "Left to right: white, yellow, cyan, green, 
magenta, red, blue, black";
  2014          case TPG_PAT_100_HCOLORBAR:
  2015                  return "Top to bottom: white, yellow, cyan, green, 
magenta, red, blue, black";
  2016          case TPG_PAT_BLACK:
  2017                  return "Black";
  2018          case TPG_PAT_WHITE:
  2019                  return "White";
  2020          case TPG_PAT_RED:
  2021                  return "Red";
  2022          case TPG_PAT_GREEN:
  2023                  return "Green";
  2024          case TPG_PAT_BLUE:
  2025                  return "Blue";
  2026          default:
> 2027                  return;
  2028          }
  2029  }
  2030  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

Attachment: .config.gz
Description: application/gzip

Reply via email to