From: Qiushi Wu <wu000...@umn.edu>

pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code, causing incorrect ref count if
pm_runtime_put_noidle() is not called in error handling paths.
Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails.

Signed-off-by: Qiushi Wu <wu000...@umn.edu>
---
 drivers/media/platform/exynos4-is/mipi-csis.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/media/platform/exynos4-is/mipi-csis.c 
b/drivers/media/platform/exynos4-is/mipi-csis.c
index 540151bbf58f..1aac167abb17 100644
--- a/drivers/media/platform/exynos4-is/mipi-csis.c
+++ b/drivers/media/platform/exynos4-is/mipi-csis.c
@@ -510,8 +510,10 @@ static int s5pcsis_s_stream(struct v4l2_subdev *sd, int 
enable)
        if (enable) {
                s5pcsis_clear_counters(state);
                ret = pm_runtime_get_sync(&state->pdev->dev);
-               if (ret && ret != 1)
+               if (ret && ret != 1) {
+                       pm_runtime_put_noidle(&state->pdev->dev);
                        return ret;
+               }
        }
 
        mutex_lock(&state->lock);
-- 
2.17.1

Reply via email to