On Thu, May 28, 2020 at 10:47:12PM +0200, Diego Rondini wrote:
> Add pwr and status leds configuration and turn on pwr led by default for 
> Orange
> Pi Zero Plus 2 (both H3 and H5 variants).
> 
> Signed-off-by: Diego Rondini <diego.rond...@kynetics.com>
> ---
>  .../boot/dts/sun8i-h3-orangepi-zero-plus2.dts    | 16 ++++++++++++++++
>  .../allwinner/sun50i-h5-orangepi-zero-plus2.dts  | 16 ++++++++++++++++
>  2 files changed, 32 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-zero-plus2.dts 
> b/arch/arm/boot/dts/sun8i-h3-orangepi-zero-plus2.dts
> index 4376767699a47..4cd0ac706bd2c 100644
> --- a/arch/arm/boot/dts/sun8i-h3-orangepi-zero-plus2.dts
> +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-zero-plus2.dts
> @@ -82,6 +82,22 @@ wifi_pwrseq: wifi_pwrseq {
>               reset-gpios = <&pio 0 9 GPIO_ACTIVE_LOW>; /* PA9 */
>               post-power-on-delay-ms = <200>;
>       };
> +
> +     leds {
> +             compatible = "gpio-leds";
> +
> +             pwr_led {
> +                     label = "orangepi:green:pwr";
> +                     gpios = <&r_pio 0 10 GPIO_ACTIVE_HIGH>;
> +                     default-state = "on";
> +             };
> +
> +             status_led {

Having an underscore in the node name will trigger a DTC warning. What
about using pwr and status as nodenames?

> +                     label = "orangepi:red:status";
> +                     gpios = <&pio 0 17 GPIO_ACTIVE_HIGH>;
> +             };
> +

There's an extra line here that you should remove

Maxime

Attachment: signature.asc
Description: PGP signature

Reply via email to