On Fri, Oct 19, 2007 at 01:13:55AM +0900, Atsushi Nemoto wrote: > This commit in current git tree broke serial console for serial_txx9 driver. > > > commit 97d97224ff361e08777fb33e0fd193ca877dac28 > > Author: Russell King <[EMAIL PROTECTED]> > > Date: Sat Sep 1 21:25:09 2007 +0100 > > > > [SERIAL] Fix console initialisation ordering > > The serial_txx9 driver initialize its port entirely on its ->pm() > method if new state was 0. With the commit, serial_core calls ->pm() > even if the port was used for console.
This'll break some of the ARM drivers, and although I investigated this a month or so ago, I've completely forgotten the details. > Attached patch fixes this problem. Is this a right way? > If not, I will fix the serial_txx9 driver to skip the initialization in > ->pm() if oldstate was -1. I'll have to investigate further to refresh myself with what's going on here, but your patch looks wrong. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
