> Subject: RE: [PATCH] soc: imx-scu: Support module build
>
> > From: Anson Huang <anson.hu...@nxp.com>
> > Sent: Wednesday, June 17, 2020 12:54 PM
> >
> > Change the configuration type to tristate, add module description,
> > author and license to support module build.
> >
> > Signed-off-by: Anson Huang <anson.hu...@nxp.com>
> > ---
> > drivers/soc/imx/Kconfig | 2 +-
> > drivers/soc/imx/soc-imx-scu.c | 5 +++++
> > 2 files changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig index
> > d515d2c..c255acb 100644
> > --- a/drivers/soc/imx/Kconfig
> > +++ b/drivers/soc/imx/Kconfig
> > @@ -9,7 +9,7 @@ config IMX_GPCV2_PM_DOMAINS
> > default y if SOC_IMX7D
> >
> > config IMX_SCU_SOC
> > - bool "i.MX System Controller Unit SoC info support"
> > + tristate "i.MX System Controller Unit SoC info support"
> > depends on IMX_SCU
> > select SOC_BUS
> > help
> > diff --git a/drivers/soc/imx/soc-imx-scu.c
> > b/drivers/soc/imx/soc-imx-scu.c index 20d37ea..bdd43ed 100644
> > --- a/drivers/soc/imx/soc-imx-scu.c
> > +++ b/drivers/soc/imx/soc-imx-scu.c
> > @@ -5,6 +5,7 @@
> >
> > #include <dt-bindings/firmware/imx/rsrc.h> #include
> > <linux/firmware/imx/sci.h>
> > +#include <linux/module.h>
> > #include <linux/slab.h>
> > #include <linux/sys_soc.h>
> > #include <linux/platform_device.h>
> > @@ -185,3 +186,7 @@ static int __init imx_scu_soc_init(void)
> > return PTR_ERR_OR_ZERO(pdev);
> > }
> > device_initcall(imx_scu_soc_init);
> > +
> > +MODULE_AUTHOR("Anson Huang <anson.hu...@nxp.com>");
> > +MODULE_DESCRIPTION("NXP i.MX SCU SoC driver");
> MODULE_LICENSE("GPL
> > +v2");
>
> I'm ok with the change. But I'm curious how can this module be autoloaded
> without MODULE_DEVICE_TABLE.
> Have you tested if it can work?
>
I ONLY tested the manual insmod, if want to support auto load, may need some
more
change, will try it later and send out a V2 if needed.
Anson
