On 17/06/2020 18.25, Jim Cromie wrote: > this is v3, changes from previous: > - moved non-controversial commits up front, refactors to help this. > - a few more minor cleanups > - left out the WIP patches > - export ddebug_exec_queries() > - accept file=foo:func only, not module:foo > - varname changes > > v2: > https://lore.kernel.org/lkml/20200613155738.2249399-1-jim.cro...@gmail.com/ > v1: https://lore.kernel.org/lkml/20200605162645.289174-1-jim.cro...@gmail.com/ > > Patchset starts with 11 cleanups; > - change section name from vague "__verbose" to "__dyndbg" > - cleaner docs, drop obsolete comment & useless debug prints, > refine verbosity, fix a BUG_ON, ram reporting miscounts. etc..
So I haven't been following too closely, but I'm also a bit skeptical about the new custom flag thing. OTOH, I'd really like to see those first cleanups go in soon, especially patch 6 - which not only makes the ram use a bit more accurate, it also avoids ~10000 calls of strlen() on cache-cold memory during boot. So, FWIW, you have my Acked-by for patches 1 through 11, and I hope those can be picked up before the next merge window. But the remaining ones seem to still require some discussion. Rasmus
