Hello everyone, In my opinion, the small and simple devm_add() helper (and its cousin, devm_vadd) can help make devm code slightly easier to write and maintain.
Would anyone care to agree or disagree? :-) Regards. On 10/03/2020 11:11, Marc Gonzalez wrote: > Differences from v4 to v5 > x Fix the grammar in devm_add comments [Geert] > x Undo an unrelated change in devm_clk_put [Geert] > > Differences from v3 to v4 > x Add a bunch of kerneldoc above devm_add() [Greg KH] > x Split patch in two [Greg KH] > > Differences from v2 to v3 > x Make devm_add() return an error-code rather than the raw data pointer > (in case devres_alloc ever returns an ERR_PTR) as suggested by Geert > x Provide a variadic version devm_vadd() to work with structs as suggested > by Geert > x Don't use nested ifs in clk_devm* implementations (hopefully simpler > code logic to follow) as suggested by Geert > > Marc Gonzalez (2): > devres: Provide new helper for devm functions > clk: Use devm_add in managed functions > > drivers/base/devres.c | 28 ++++++++++++ > drivers/clk/clk-devres.c | 97 +++++++++++++++------------------------- > include/linux/device.h | 3 ++ > 3 files changed, 67 insertions(+), 61 deletions(-)
