On Thu, Jun 18, 2020 at 12:12:06AM -0700, Christoph Hellwig wrote: > On Wed, Jun 17, 2020 at 11:23:41AM -0700, Fenghua Yu wrote: > > PASID is defined as a few different types in iommu including "int", > > "u32", and "unsigned int". To be consistent and to match with ioasid's > > type, define PASID and its variations (e.g. max PASID) as "unsigned int". > > Wouldn't u32 be a little more explicit (besides being shorter and > matching the uapi definitions)?
"unsigned int" matches ioasid_t type definition. Very (very) few places define pasid as "u32". If changing to u32, this patch will be much bigger. include/uapi/linux/iommu.h defines pasid as either __u32 or __u64. It's not just __u32. Thanks. -Fenghua
