Hi Niklas, I love your patch! Yet something to improve:
[auto build test ERROR on block/for-next] [also build test ERROR on linus/master v5.8-rc1 next-20200618] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Niklas-Cassel/nvme-remove-workarounds-for-gcc-bug-wrt-unnamed-fields-in-initializers/20200618-223525 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next config: x86_64-allyesconfig (attached as .config) compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 487ca07fcc75d52755c9fe2ee05bcb3b6eeeec44) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): >> drivers/nvme/target/rdma.c:1543:20: error: use of undeclared identifier >> 'priv' .private_data = &priv, ^ drivers/nvme/target/rdma.c:1544:30: error: use of undeclared identifier 'priv' .private_data_len = sizeof(priv), ^ 2 errors generated. vim +/priv +1543 drivers/nvme/target/rdma.c 1533 1534 static int nvmet_rdma_cm_accept(struct rdma_cm_id *cm_id, 1535 struct nvmet_rdma_queue *queue, 1536 struct rdma_conn_param *p) 1537 { 1538 struct rdma_conn_param param = { 1539 .rnr_retry_count = 7, 1540 .flow_control = 1, 1541 .initiator_depth = min_t(u8, p->initiator_depth, 1542 queue->dev->device->attrs.max_qp_init_rd_atom), > 1543 .private_data = &priv, 1544 .private_data_len = sizeof(priv), 1545 }; 1546 struct nvme_rdma_cm_rep priv = { 1547 .recfmt = cpu_to_le16(NVME_RDMA_CM_FMT_1_0), 1548 .crqsize = cpu_to_le16(queue->recv_queue_size), 1549 }; 1550 int ret = -ENOMEM; 1551 1552 ret = rdma_accept(cm_id, ¶m); 1553 if (ret) 1554 pr_err("rdma_accept failed (error code = %d)\n", ret); 1555 1556 return ret; 1557 } 1558 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
