On Mon, Jun 22, 2020 at 09:45:35PM +0200, Rafael J. Wysocki wrote: > On Mon, Jun 22, 2020 at 7:16 PM Chen Yu <[email protected]> wrote: > > > > Hi Rafael, > > On Mon, Jun 22, 2020 at 06:19:35PM +0200, Rafael J. Wysocki wrote: > > [cut] > > > > +{ > > > > + if (!current_clr_polling_and_test()) > > > > + s2idle_enter(drv, dev, index); > > > > + > > > > + return index; > > > > > > Is the value returned here used at all? > > > > > It is not used for now IMO. > > > > */ > > > > index = find_deepest_state(drv, dev, U64_MAX, 0, true); > > > > if (index > 0) > > > > - enter_s2idle_proper(drv, dev, index); > > > > + call_s2idle(drv, dev, index); > > > > > > I'm wondering why this can't be > > > > > > if (index > 0 && !current_clr_polling_and_test()) > > > enter_s2idle_proper(drv, dev, index); > > > > > Yes, it should be simpler, but I guess Peter was trying to > > make call_s2idle() consistent with call_cpuidle(), > > and also s2idle_enter() is analogous to cpuidle_enter(). > > So IMO it would be better to do the simplest fix first and then do the > cleanup on top of it. > Okay, I'll do that.
Thanks, Chenyu
