From: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> [ Upstream commit 8893ab5e8ee5d7c12e0fc1dca4a309475064473d ]
The error handling flow seems incorrect, there is no reason to try and add debugfs support if the device registration did not succeed. Return on error. Signed-off-by: Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> Signed-off-by: Bard Liao <yung-chuan.l...@linux.intel.com> Reviewed-by: Ranjani Sridharan <ranjani.sridha...@linux.intel.com> Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovet...@linux.intel.com> Link: https://lore.kernel.org/r/20200419185117.4233-2-yung-chuan.l...@linux.intel.com Signed-off-by: Vinod Koul <vk...@kernel.org> Signed-off-by: Sasha Levin <sas...@kernel.org> --- drivers/soundwire/slave.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/soundwire/slave.c b/drivers/soundwire/slave.c index 6473fa602f82c..611f4f5bc36ab 100644 --- a/drivers/soundwire/slave.c +++ b/drivers/soundwire/slave.c @@ -57,6 +57,8 @@ static int sdw_slave_add(struct sdw_bus *bus, list_del(&slave->node); mutex_unlock(&bus->bus_lock); put_device(&slave->dev); + + return ret; } sdw_slave_debugfs_init(slave); -- 2.25.1
