Hi Masami, On Sat, 2020-06-20 at 12:45 +0900, Masami Hiramatsu wrote: > Hi, > > These are some fixes which I found recentry on ftrace. > > - Since the boot-time tracing synthetic event feature is decoupled > from trigger recenty, it should use CONFIG_SYNTH_EVENT.
Oops, yeah, I missed this one in the update, thanks for finding it. > - The parser of event trigger seems rejecting some redundant > spaces. But it is hard users to find the wrong point. Such > spaces should be accepted. > Agreed, your patch makes things much better, thanks. You can add my reviewed-by for both patches. Reviewed-by: Tom Zanussi <zanu...@kernel.org> Thanks, Tom > BTW, I also found the trigger parser accepts some inputs which > may not correctly formatted, e.g. > > # echo "traceon 1" > events/ftrace/print/trigger > > (from the document, it must be "traceon:1") > But I think this does not decrease the usability. > > Thank you, > > --- > > Masami Hiramatsu (2): > tracing/boot: Fix config dependency for synthedic event > tracing: Fix event trigger to accept redundant spaces > > > kernel/trace/trace_boot.c | 2 +- > kernel/trace/trace_events_trigger.c | 21 +++++++++++++++++++-- > 2 files changed, 20 insertions(+), 3 deletions(-) > > -- > Masami Hiramatsu (Linaro) <mhira...@kernel.org>
