* Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote:
> Ingo Molnar wrote:
> > we should kill it there too.
> >
> > the only place where we should _please_ keep those annotations are for
> > functions that get called from assembly code. This makes life immensely
> > easier for -pg (CONFIG_FUNCTION_TRACING) kernels.
>
> Should we re-add them for the function pointers in asm-x86/paravirt.h?
yes, yes, yes. :-) It was a nightmare to sort it out in -rt (and still
is). It's also good documentation - it pinpoints functions that are
called from assembly.
> Andi argued we should remove them since x86 is unconditionally regparm
> now anyway - and they're pretty ugly syntactically.
Sure, it doesnt make things prettier, but i didnt see any particular
ugliness.
Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
