On Wed, Jun 24, 2020 at 5:40 AM Dariusz Marcinkiewicz <dar...@google.com> wrote: > > Hello. > > I realized that I sent the previous answer using HTML, and as a > consequence it was blocked from mailing lists. Sending it again > (apologies for double posting). > > On Mon, Jun 22, 2020 at 12:23 PM Hans Verkuil <hverkuil-ci...@xs4all.nl> > wrote: > > > > On 22/06/2020 12:05, Dariusz Marcinkiewicz wrote: > > > Do not fail probing when device_init_wakeup fails. > > > > > > device_init_wakeup fails when the device is already enabled as wakeup > > > device. Hence, the driver fails to probe the device if: > > > - The device has already been enabled for wakeup (via e.g. sysfs) > > > - The driver has been unloaded and is being loaded again. > > > > > > This goal of the patch is to fix the above cases. > > > > > > Overwhelming majority of the drivers do not check device_init_wakeup > > > return value. > > > > > > Signed-off-by: Dariusz Marcinkiewicz <dar...@google.com> > > > > This can be CCed to stable, I guess? > > > > That issue is not a recent regression but has been in there since the > very beginning. So it might be argued that is it not severe enough to > warrant cc'ing stable. Happy to do that anyways if you think > otherwise. >
Confused. Internally you would like to have this patch applied to chromeos-4.4. Here you suggest that it may not be important enough to apply to stable releases. Which one is it ? Thanks, Guenter > > Can you provide a Fixes: tag as well? > > > > Done, submitted v2 with that a couple of days ago. > > Thank you and best regards.
