On Fri, Jun 26, 2020 at 07:09:03PM +1200, Barry Song wrote:
>
> +     mutex_lock(&acomp_ctx->mutex);
> +
> +     src = kmap(page);
> +     dst = acomp_ctx->dstmem;
> +     sg_init_one(&input, src, PAGE_SIZE);
> +     /* zswap_dstmem is of size (PAGE_SIZE * 2). Reflect same in sg_list */
> +     sg_init_one(&output, dst, PAGE_SIZE * 2);
> +     acomp_request_set_params(acomp_ctx->req, &input, &output, PAGE_SIZE, 
> dlen);
> +     ret = crypto_wait_req(crypto_acomp_compress(acomp_ctx->req), 
> &acomp_ctx->wait);
> +     dlen = acomp_ctx->req->dlen;
> +     kunmap(page);

Waiting on an async request like this is just silly.  This defeats
the whole purpose of having a fallback.

Cheers,
-- 
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Reply via email to