Hi Dan > -----Original Message----- > The "head" pointer can't be NULL because it points to an address in the middle > of a ufs_hba struct. Looking at this code, probably someone would wonder if > the intent was to check whether "hba" is NULL, but "hba" > isn't NULL and the check can just be removed. > > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> > --- Please add Fixes: tag With that Acked-by: Alim Akhtar <alim.akh...@samsung.com>
Thanks! > drivers/scsi/ufs/ufs-exynos.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/ufs/ufs-exynos.c b/drivers/scsi/ufs/ufs-exynos.c index > 16544b3dad47..802f7de626e8 100644 > --- a/drivers/scsi/ufs/ufs-exynos.c > +++ b/drivers/scsi/ufs/ufs-exynos.c > @@ -264,7 +264,7 @@ static int exynos_ufs_get_clk_info(struct exynos_ufs > *ufs) > u8 div = 0; > int ret = 0; > > - if (!head || list_empty(head)) > + if (list_empty(head)) > goto out; > > list_for_each_entry(clki, head, list) { > -- > 2.27.0