Hi Stephen,
> -----Original Message----- > From: Stephen Hemminger <[email protected]> > Sent: 2020年6月29日 4:16 > To: Po Liu <[email protected]> > Cc: [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; Claudiu Manoil <[email protected]>; Vladimir > Oltean <[email protected]>; Alexandru Marginean > <[email protected]> > Subject: Re: [iproute2-next] action police: make 'mtu' could be set > independently in police action > > On Sun, 28 Jun 2020 09:46:02 +0800 > Po Liu <[email protected]> wrote: > > > Current police action must set 'rate' and 'burst'. 'mtu' parameter set > > the max frame size and could be set alone without 'rate' and 'burst' > > in some situation. Offloading to hardware for example, 'mtu' could > > limit the flow max frame size. > > > > Signed-off-by: Po Liu <[email protected]> > > --- > > tc/m_police.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/tc/m_police.c b/tc/m_police.c index a5bc20c0..89497f67 > > 100644 > > --- a/tc/m_police.c > > +++ b/tc/m_police.c > > @@ -161,8 +161,8 @@ action_ctrl_ok: > > return -1; > > > > /* Must at least do late binding, use TB or ewma policing */ > > - if (!rate64 && !avrate && !p.index) { > > - fprintf(stderr, "\"rate\" or \"avrate\" MUST be > > specified.\n"); > > + if (!rate64 && !avrate && !p.index && !mtu) { > > + fprintf(stderr, "\"rate\" or \"avrate\" or \"mtu\"MUST > > + be specified.\n"); > > Missing blank. > Your message will come out as: > "rate" or "avrate" or "mtu"MUST be specified. Get it. Will correct. Thanks! > > > The quotes aren't adding to the readability, why not just remove them > instead. Will remove all quotes. Br, Po Liu
