On Mon, Jun 29, 2020 at 07:36:15AM -0700, Dave Hansen wrote: > On 6/29/20 12:13 AM, Daniel Wagner wrote: > > I went to go add a new RECLAIM_* mode for the zone_reclaim_mode > > sysctl. > > This conveys my motivation.
You don't need to tell a story. As explained in the documetation 'Describe your changes', describe your change in imperative mood, e.g. something like "Add RECLAIM_* mode for the the zone_reclaim_mode sysctl." > > Like a good kernel developer, I also went to go update the > > documentation. > > This takes the opportunity to throw a tiny bit of shade in the direction > of the other folks who modified the #define without updating the > documentation. What about something simple as, "Update the documetation to match the implementation" or whatever makes it clear why you are touching the documetation bits. Anyway, I just wanted to help you to write better commit messages. I understand, my help is not welcome.
