Hi "周琰杰,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on clk/clk-next]
[also build test WARNING on linux/master linus/master v5.8-rc3 next-20200629]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Zhou-Yanjie/Add-functions-to-operate-USB-PHY-related-clock/20200629-011858
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: alpha-allyesconfig (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross 
ARCH=alpha 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>

All warnings (new ones prefixed by >>):

   In file included from arch/alpha/include/asm/bug.h:23,
                    from include/linux/bug.h:5,
                    from include/linux/thread_info.h:12,
                    from include/asm-generic/current.h:5,
                    from ./arch/alpha/include/generated/asm/current.h:1,
                    from include/linux/mutex.h:14,
                    from include/linux/kernfs.h:12,
                    from include/linux/sysfs.h:16,
                    from include/linux/kobject.h:20,
                    from include/linux/of.h:17,
                    from include/linux/clk-provider.h:9,
                    from drivers/clk/ingenic/x1000-cgu.c:7:
   drivers/clk/ingenic/x1000-cgu.c: In function 'x1000_otg_phy_recalc_rate':
   include/asm-generic/bug.h:127:34: error: expected expression before ')' token
     127 |  int __ret_warn_on = !!(condition);    \
         |                                  ^
>> drivers/clk/ingenic/x1000-cgu.c:83:2: note: in expansion of macro 'WARN'
      83 |  WARN();
         |  ^~~~
   include/asm-generic/bug.h:88:51: error: expected expression before ')' token
      88 |   warn_slowpath_fmt(__FILE__, __LINE__, taint, arg); \
         |                                                   ^
   include/asm-generic/bug.h:129:3: note: in expansion of macro '__WARN_printf'
     129 |   __WARN_printf(TAINT_WARN, format);   \
         |   ^~~~~~~~~~~~~
>> drivers/clk/ingenic/x1000-cgu.c:83:2: note: in expansion of macro 'WARN'
      83 |  WARN();
         |  ^~~~

vim +/WARN +83 drivers/clk/ingenic/x1000-cgu.c

    62  
    63  static unsigned long x1000_otg_phy_recalc_rate(struct clk_hw *hw,
    64                                                  unsigned long 
parent_rate)
    65  {
    66          u32 usbpcr1;
    67          unsigned refclk_div;
    68  
    69          usbpcr1 = readl(cgu->base + CGU_REG_USBPCR1);
    70          refclk_div = usbpcr1 & USBPCR1_REFCLKDIV_MASK;
    71  
    72          switch (refclk_div) {
    73          case USBPCR1_REFCLKDIV_12:
    74                  return 12000000;
    75  
    76          case USBPCR1_REFCLKDIV_24:
    77                  return 48000000;
    78  
    79          case USBPCR1_REFCLKDIV_48:
    80                  return 48000000;
    81          }
    82  
  > 83          WARN();
    84          return parent_rate;
    85  }
    86  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org

Attachment: .config.gz
Description: application/gzip

Reply via email to