Re: [PATCH v3 2/2] Add PWM fan controller driver for LGM SoC

Mon, 29 Jun 2020 12:59:58 -0700 

Hello,

On Mon, Jun 29, 2020 at 05:03:47PM +0800, Rahul Tanwar wrote:
> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> index cb8d739067d2..a3303e22d5fa 100644
> --- a/drivers/pwm/Kconfig
> +++ b/drivers/pwm/Kconfig
> @@ -232,6 +232,15 @@ config PWM_IMX_TPM
>         To compile this driver as a module, choose M here: the module
>         will be called pwm-imx-tpm.
>  
> +config PWM_INTEL_LGM
> +     tristate "Intel LGM PWM support"
> +     depends on X86 || COMPILE_TEST

Another thing I just noticed: You're using regmap, so I think you should
have

        select REGMAP_MMIO

here.

> +     help
> +       Generic PWM fan controller driver for LGM SoC.
> +
> +       To compile this driver as a module, choose M here: the module
> +       will be called pwm-intel-lgm.
> +

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature

Reply via email to