From: Waiman Long <long...@redhat.com> commit 8982ae527fbef170ef298650c15d55a9ccd33973 upstream.
The kzfree() function is normally used to clear some sensitive information, like encryption keys, in the buffer before freeing it back to the pool. Memset() is currently used for buffer clearing. However unlikely, there is still a non-zero probability that the compiler may choose to optimize away the memory clearing especially if LTO is being used in the future. To make sure that this optimization will never happen, memzero_explicit(), which is introduced in v3.18, is now used in kzfree() to future-proof it. Link: http://lkml.kernel.org/r/20200616154311.12314-2-long...@redhat.com Fixes: 3ef0e5ba4673 ("slab: introduce kzfree()") Signed-off-by: Waiman Long <long...@redhat.com> Acked-by: Michal Hocko <mho...@suse.com> Cc: David Howells <dhowe...@redhat.com> Cc: Jarkko Sakkinen <jarkko.sakki...@linux.intel.com> Cc: James Morris <jmor...@namei.org> Cc: "Serge E. Hallyn" <se...@hallyn.com> Cc: Joe Perches <j...@perches.com> Cc: Matthew Wilcox <wi...@infradead.org> Cc: David Rientjes <rient...@google.com> Cc: Johannes Weiner <han...@cmpxchg.org> Cc: Dan Carpenter <dan.carpen...@oracle.com> Cc: "Jason A . Donenfeld" <ja...@zx2c4.com> Cc: <sta...@vger.kernel.org> Signed-off-by: Andrew Morton <a...@linux-foundation.org> Signed-off-by: Linus Torvalds <torva...@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- mm/slab_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/slab_common.c b/mm/slab_common.c index 39e382acb0b86..b5776b1301f0c 100644 --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -1540,7 +1540,7 @@ void kzfree(const void *p) if (unlikely(ZERO_OR_NULL_PTR(mem))) return; ks = ksize(mem); - memset(mem, 0, ks); + memzero_explicit(mem, ks); kfree(mem); } EXPORT_SYMBOL(kzfree); -- 2.25.1
