On Mon, Jun 29, 2020 at 1:03 PM Joe Perches <[email protected]> wrote: > > On Mon, 2020-06-29 at 12:53 -0700, Nick Desaulniers wrote: > > On Sun, Jun 28, 2020 at 11:18 PM Kees Cook <[email protected]> wrote: > > > Fix a case of needless quotes in __section(), which Clang doesn't like. > > > > > > Acked-by: Will Deacon <[email protected]> > > > Signed-off-by: Kees Cook <[email protected]> > > > > Yep, I remember bugs from this. Probably should scan the kernel for > > other instances of this. +Joe for checkpatch.pl validation. > > Reviewed-by: Nick Desaulniers <[email protected]> > > $ git grep -P -n '__section\s*\(\s*\"' > arch/arm64/mm/mmu.c:45:u64 __section(".mmuoff.data.write") vabits_actual; > include/linux/compiler.h:211: __section("___kentry" "+" #sym ) > \ > include/linux/export.h:133: static int __ksym_marker_##sym[0] > __section(".discard.ksym") __used > include/linux/srcutree.h:127: __section("___srcu_struct_ptrs") = > &name > > My recollection is I submitted a patch > to _add_ quotes > > https://lore.kernel.org/patchwork/patch/1125785/
Hey, yeah! Did you end up sending v2? -- Thanks, ~Nick Desaulniers
