On Mon, Jun 29, 2020 at 8:06 AM Anson Huang <anson.hu...@nxp.com> wrote: > > Support building i.MX8QXP clock driver as module. > > Signed-off-by: Anson Huang <anson.hu...@nxp.com>
I would just combine the per-soc patches into one, as they all have the same changelog text. > diff --git a/drivers/clk/imx/clk-imx8qxp-lpcg.c > b/drivers/clk/imx/clk-imx8qxp-lpcg.c > index 04c8ee3..8afaefc 100644 > --- a/drivers/clk/imx/clk-imx8qxp-lpcg.c > +++ b/drivers/clk/imx/clk-imx8qxp-lpcg.c > @@ -232,3 +232,4 @@ static struct platform_driver imx8qxp_lpcg_clk_driver = { > }; > > builtin_platform_driver(imx8qxp_lpcg_clk_driver); > +MODULE_LICENSE("GPL v2"); Same thing here: please try to make it possible to unload these drivers, and add MODULE_AUTHOR/MODULE_DESCRIPTION tags in addition to MODULE_LICENSE. Arnd