On 10/23/07, Domen Puncer <[EMAIL PROTECTED]> wrote: > On 23/10/07 21:39 -0600, Grant Likely wrote: > > From: Grant Likely <[EMAIL PROTECTED]> > > > > port_config and the cdm are the responsibility of firmware; and if > > firmware doesn't set it up correctly, it should be fixed up by > > platform code on a per-board basis because it's a property of the > > board. > > > > Drivers should never touch these registers. They are completely > > unprotected and the platform may do odd things with them that the > > driver must not interfere with. > > > > Signed-off-by: Grant Likely <[EMAIL PROTECTED]> > > --- > > > > Domen, Dragos; can you please check your usage of this driver. None of > > the in-tree board ports use it as-is, but they are of course just a > > device tree change away from being usable on the lite5200b. > > My test cases were just a jumper on RX-TX line. > > It's not even allowed to set mclken_div_pscX? > There can be different speed devices on same SPI > (spi_board_info->max_speed_hz).
Nope; do it in the platform code or a cdm driver. Otherwise there is no protection against collisions on the cdm registers. The driver could call a platform hook to fiddle with clocking, but it must not touch it directly. (BTW, I don't intended to push this version of the patch; I just want to get everyone's brain juices flowing to figure out the best way to solve it.) Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. [EMAIL PROTECTED] (403) 399-0195 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
