Re: [PATCH v6 13/13] arm64: dts: sun50i-a64-pinephone: Add touchscreen support

[Icenowy Zheng]

于 2020年7月1日 GMT+08:00 下午6:31:26, Ondrej Jirman <meg...@megous.com> 写到:
>Pinephone has a Goodix GT917S capacitive touchscreen controller on
>I2C0 bus. Add support for it.
>
>Signed-off-by: Ondrej Jirman <meg...@megous.com>
>Acked-by: Linus Walleij <linus.wall...@linaro.org>
>---
> .../dts/allwinner/sun50i-a64-pinephone.dtsi   | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
>diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
>b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
>index 85a7aa5efd32..2d5694446d17 100644
>--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
>+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
>@@ -123,6 +123,25 @@ &ehci1 {
>       status = "okay";
> };
> 
>+&i2c0 {
>+      pinctrl-names = "default";
>+      pinctrl-0 = <&i2c0_pins>;
>+      status = "okay";
>+
>+      touchscreen@5d {
>+              compatible = "goodix,gt917s", "goodix,gt911";

Please drop gt911 here. GT917S belong to the GT1x product line, not the same 
line with GT911.

You will see this in the driver.

>+              reg = <0x5d>;
>+              interrupt-parent = <&pio>;
>+              interrupts = <7 4 IRQ_TYPE_LEVEL_HIGH>; /* PH4 */
>+              irq-gpios = <&pio 7 4 GPIO_ACTIVE_HIGH>; /* PH4 */
>+              reset-gpios = <&pio 7 11 GPIO_ACTIVE_HIGH>; /* PH11 */
>+              AVDD28-supply = <&reg_ldo_io0>;
>+              VDDIO-supply = <&reg_ldo_io0>;
>+              touchscreen-size-x = <720>;
>+              touchscreen-size-y = <1440>;
>+      };
>+};
>+
> &i2c1 {
>       status = "okay";
>