On Wed, 24 Oct 2007 17:22:40 +0200 Wim Van Sebroeck <[EMAIL PROTECTED]> wrote:
> Hi Andrew, > > > > + case WDIOC_SETOPTIONS:{ > > > + int retval = -EINVAL; > > > + > > > + if (arg & WDIOS_DISABLECARD) { > > > + wdt_disable(); > > > + retval = 0; > > > + } > > > + > > > + if (arg & WDIOS_ENABLECARD) { > > > + wdt_enable(); > > > + retval = 0; > > > + } > > > + > > > + return retval; > > > > hrm. So if userspace does ioctl(..., WDIOS_DISABLECARD|WDIOS_ENABLECARD, > > that happens to be equivalent to WDIOS_ENABLECARD? > > > > Do all watchdog drivers do it exactly the same way, or are we offering > > inconsistent interfaces between different drivers? > > I fear that all watchdog drivers do it more or less like this. Not really an issue. "Mummy if I jump off a cliff it hurts" - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/