On 7/3/20 10:41 AM, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/usb/typec/tcpm/fusb302.c: In function ‘fusb302_log’:
>  drivers/usb/typec/tcpm/fusb302.c:186:2: warning: function ‘fusb302_log’ 
> might be a candidate for ‘gnu_printf’ format attribute 
> [-Wsuggest-attribute=format]
>  186 | _fusb302_log(chip, fmt, args);
>  | ^~~~~~~~~~~~
> 
> Cc: Guenter Roeck <li...@roeck-us.net>
> Cc: Heikki Krogerus <heikki.kroge...@linux.intel.com>
> Cc: Yueyao Zhu <yueyao....@gmail.com>
> Signed-off-by: Lee Jones <lee.jo...@linaro.org>

Reviewed-by: Guenter Roeck <li...@roeck-us.net>
> ---
>  drivers/usb/typec/tcpm/fusb302.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/typec/tcpm/fusb302.c 
> b/drivers/usb/typec/tcpm/fusb302.c
> index b28facece43c4..99562cc65ca69 100644
> --- a/drivers/usb/typec/tcpm/fusb302.c
> +++ b/drivers/usb/typec/tcpm/fusb302.c
> @@ -178,6 +178,7 @@ static void _fusb302_log(struct fusb302_chip *chip, const 
> char *fmt,
>       mutex_unlock(&chip->logbuffer_lock);
>  }
>  
> +__printf(2, 3)
>  static void fusb302_log(struct fusb302_chip *chip, const char *fmt, ...)
>  {
>       va_list args;
> 

Reply via email to