Hi Matthias, thanks for your comment
On Mon, 2020-07-06 at 16:03 +0200, Matthias Brugger wrote: > > On 05/07/2020 08:48, Dennis YC Hsieh wrote: > > Add address shift when compose jump instruction > > to compatible with 35bit format. > > > > Signed-off-by: Dennis YC Hsieh <dennis-yc.hs...@mediatek.com> > > You are missing Bibby's Reviewed-by. Please honour the effort reviewers do by > adding the appropriate tags. > > Please double check the series and resend with all tags added. > > Also, it would be good if you could provide a change log. That makes it easier > for the maintainer to see which statements you addressed. this patch changed since cmdq_mbox_shift() rename to cmdq_get_shift_pa() by Bibby's comment [1], so I removed reviewed tags from this patch. I'll provide change log to this patch and resend later, thanks. [1] http://lists.infradead.org/pipermail/linux-mediatek/2020-June/013387.html Regards, Dennis > > Thanks, > Matthias > > > --- > > drivers/soc/mediatek/mtk-cmdq-helper.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c > > b/drivers/soc/mediatek/mtk-cmdq-helper.c > > index dc644cfb6419..9faf78fbed3a 100644 > > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > > @@ -329,7 +329,8 @@ int cmdq_pkt_finalize(struct cmdq_pkt *pkt) > > > > /* JUMP to end */ > > inst.op = CMDQ_CODE_JUMP; > > - inst.value = CMDQ_JUMP_PASS; > > + inst.value = CMDQ_JUMP_PASS >> > > + cmdq_get_shift_pa(((struct cmdq_client *)pkt->cl)->chan); > > err = cmdq_pkt_append_command(pkt, inst); > > > > return err; > >
