On Fri, Jul 03, 2020 at 03:40:59PM +0900, Namhyung Kim wrote:
> On Sat, Jun 27, 2020 at 10:38 PM Changbin Du <changbin...@gmail.com> wrote:
> >
> > This adds an option '--graph-nosleep-time' which allow us only to measure
> > on-CPU time. This option is function_graph tracer only.
>
> I'd suggest --graph-sleep-time instead and set it by default.
> Then we can have --no-graph-sleep-time as well.
>
If so can we make --graph-sleep-time as default. Seems there is no something
like OPT_BOOLEAN_DEFAULT().
> By the way, didn't we agree to have something like --graph-opts instead?
>
As I mentioned in previous version, --graph-opts make the parsing a little
complex.
--graph-opts depth=<n>,nosleep_time,noirqs,no_tail,verbose
While the exsiting style is '--graph-depth <n>'. The cons is we must type more
characters. The pros is don't need to reimplement parsing and align with old
behaviour.
--graph-depth <n>
--graph-nosleep-time
--graph-noirqs
--graph-notail
--graph-verbose
> Thanks
> Namhyung
>
> >
> > Signed-off-by: Changbin Du <changbin...@gmail.com>
> >
--
Cheers,
Changbin Du
