Hi Matthew > -----Original Message----- > From: Matthew Wilcox <[email protected]> > Sent: Thursday, July 9, 2020 10:11 AM > To: Justin He <[email protected]> > Cc: Catalin Marinas <[email protected]>; Will Deacon > <[email protected]>; Tony Luck <[email protected]>; Fenghua Yu > <[email protected]>; Yoshinori Sato <[email protected]>; Rich > Felker <[email protected]>; Dave Hansen <[email protected]>; Andy > Lutomirski <[email protected]>; Peter Zijlstra <[email protected]>; > Thomas Gleixner <[email protected]>; Ingo Molnar <[email protected]>; > Borislav Petkov <[email protected]>; David Hildenbrand <[email protected]>; > [email protected]; H. Peter Anvin <[email protected]>; Dan Williams > <[email protected]>; Vishal Verma <[email protected]>; Dave > Jiang <[email protected]>; Andrew Morton <[email protected]>; > Baoquan He <[email protected]>; Chuhong Yuan <[email protected]>; Mike > Rapoport <[email protected]>; Logan Gunthorpe <[email protected]>; > Masahiro Yamada <[email protected]>; Michal Hocko <[email protected]>; > [email protected]; [email protected]; linux- > [email protected]; [email protected]; [email protected]; > [email protected]; Jonathan Cameron <[email protected]>; Kaly > Xin <[email protected]> > Subject: Re: [PATCH v3 4/6] mm: don't export memory_add_physaddr_to_nid in > arch specific directory > > On Thu, Jul 09, 2020 at 10:06:27AM +0800, Jia He wrote: > > After a general version of __weak memory_add_physaddr_to_nid implemented > > and exported , it is no use exporting twice in arch directory even if > > e,g, ia64/x86 have their specific version. > > > > This is to suppress the modpost warning: > > WARNING: modpost: vmlinux: 'memory_add_physaddr_to_nid' exported twice. > > Previous export was in vmlinux > > It's bad form to introduce a warning and then send a follow-up patch to > fix the warning. Just fold this patch into patch 1/6. Thanks, will do
Cheers, Justin He
