On Fri, Jul 10, 2020 at 04:48:37PM +0800, Qiwu Huang wrote:
> From: Qiwu Huang <huangq...@xiaomi.com>
>
> Reports the kind of quick charge type based on
> different adapter power. UI will show different
> animation effect for different quick charge type.
>
> Signed-off-by: Qiwu Huang <huangq...@xiaomi.com>
> ---
> Documentation/ABI/testing/sysfs-class-power | 10 ++++++++++
> drivers/power/supply/power_supply_sysfs.c | 1 +
> include/linux/power_supply.h | 1 +
> 3 files changed, 12 insertions(+)
>
> diff --git a/Documentation/ABI/testing/sysfs-class-power
> b/Documentation/ABI/testing/sysfs-class-power
> index 216d61a22f1e..0d9d6b46e239 100644
> --- a/Documentation/ABI/testing/sysfs-class-power
> +++ b/Documentation/ABI/testing/sysfs-class-power
> @@ -708,3 +708,13 @@ Description:
>
> Access: Read
> Valid values: 1-31
> +
> +What: /sys/class/power_supply/<supply_name>/quick_charge_type
> +Date: Jul 2020
> +Contact: Fei Jiang <jiangf...@xiaomi.com>
> + Description:
> + Reports the kind of quick charge type based on different
> adapter power.
> +
> + Access: Read-Only
> + Valid values: "QUICK_CHARGE_NORMAL", "QUICK_CHARGE_FAST",
> "QUICK_CHARGE_FLASH",
> + "QUICK_CHARGE_TURBE", "QUICK_CHARGE_SUPER".
"QUICK_CHARGE_TURBO"?
> diff --git a/drivers/power/supply/power_supply_sysfs.c
> b/drivers/power/supply/power_supply_sysfs.c
> index bc79560229b5..f95574c41898 100644
> --- a/drivers/power/supply/power_supply_sysfs.c
> +++ b/drivers/power/supply/power_supply_sysfs.c
> @@ -206,6 +206,7 @@ static struct power_supply_attr power_supply_attrs[] = {
> POWER_SUPPLY_ATTR(MODEL_NAME),
> POWER_SUPPLY_ATTR(MANUFACTURER),
> POWER_SUPPLY_ATTR(SERIAL_NUMBER),
> + POWER_SUPPLY_ATTR(quick_charge_type),
Shouldn't this be all uppercase:
QUICK_CHARGE_TYPE
?
And shouldn't there be a string with the expected values somewhere?
thanks,
greg k-h
