From: Tom Rix <t...@redhat.com>

clang static analysis flags this error

lib/decompress_bunzip2.c:671:13: warning: Result of 'malloc' is converted
  to a pointer of type 'unsigned int', which is incompatible with sizeof
  operand type 'int' [unix.MallocSizeof]
        bd->dbuf = large_malloc(bd->dbufSize * sizeof(int));
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Reviewing the bunzip_data structure, the element dbuf is type

        /* Intermediate buffer and its size (in bytes) */
        unsigned int *dbuf, dbufSize;

So change the type in sizeof to 'unsigned int'

Fixes: bc22c17e12c1 ("bzip2/lzma: library support for gzip, bzip2 and lzma 
decompression")

Signed-off-by: Tom Rix <t...@redhat.com>
---
 lib/decompress_bunzip2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/decompress_bunzip2.c b/lib/decompress_bunzip2.c
index 7c4932eed748..59ab76bda7a7 100644
--- a/lib/decompress_bunzip2.c
+++ b/lib/decompress_bunzip2.c
@@ -668,7 +668,7 @@ static int INIT start_bunzip(struct bunzip_data **bdp, void 
*inbuf, long len,
           uncompressed data.  Allocate intermediate buffer for block. */
        bd->dbufSize = 100000*(i-BZh0);
 
-       bd->dbuf = large_malloc(bd->dbufSize * sizeof(int));
+       bd->dbuf = large_malloc(bd->dbufSize * sizeof(unsigned int));
        if (!bd->dbuf)
                return RETVAL_OUT_OF_MEMORY;
        return RETVAL_OK;
-- 
2.18.1

Reply via email to