On 7/14/20 5:07 PM, Lee Jones wrote:
Mostly missing or incorrect (bitrotted) function parameters.

Fixes the following W=1 kernel build warning(s):

  drivers/scsi/fcoe/fcoe_ctlr.c:139: warning: Function parameter or member 
'mode' not described in 'fcoe_ctlr_init'
  drivers/scsi/fcoe/fcoe_ctlr.c:604: warning: Function parameter or member 
'lport' not described in 'fcoe_ctlr_encaps'
  drivers/scsi/fcoe/fcoe_ctlr.c:1312: warning: Function parameter or member 
'skb' not described in 'fcoe_ctlr_recv_clr_vlink'
  drivers/scsi/fcoe/fcoe_ctlr.c:1312: warning: Excess function parameter 'fh' 
description in 'fcoe_ctlr_recv_clr_vlink'
  drivers/scsi/fcoe/fcoe_ctlr.c:1781: warning: Function parameter or member 't' 
not described in 'fcoe_ctlr_timeout'
  drivers/scsi/fcoe/fcoe_ctlr.c:1781: warning: Excess function parameter 'arg' 
description in 'fcoe_ctlr_timeout'
  drivers/scsi/fcoe/fcoe_ctlr.c:1904: warning: Function parameter or member 
'lport' not described in 'fcoe_ctlr_recv_flogi'
  drivers/scsi/fcoe/fcoe_ctlr.c:2166: warning: Function parameter or member 
'lport' not described in 'fcoe_ctlr_disc_stop_locked'
  drivers/scsi/fcoe/fcoe_ctlr.c:2166: warning: Excess function parameter 'fip' 
description in 'fcoe_ctlr_disc_stop_locked'
  drivers/scsi/fcoe/fcoe_ctlr.c:2188: warning: Function parameter or member 
'lport' not described in 'fcoe_ctlr_disc_stop'
  drivers/scsi/fcoe/fcoe_ctlr.c:2188: warning: Excess function parameter 'fip' 
description in 'fcoe_ctlr_disc_stop'
  drivers/scsi/fcoe/fcoe_ctlr.c:2204: warning: Function parameter or member 
'lport' not described in 'fcoe_ctlr_disc_stop_final'
  drivers/scsi/fcoe/fcoe_ctlr.c:2204: warning: Excess function parameter 'fip' 
description in 'fcoe_ctlr_disc_stop_final'
  drivers/scsi/fcoe/fcoe_ctlr.c:2273: warning: Function parameter or member 
'frport' not described in 'fcoe_ctlr_vn_parse'
  drivers/scsi/fcoe/fcoe_ctlr.c:2273: warning: Excess function parameter 
'rdata' description in 'fcoe_ctlr_vn_parse'
  drivers/scsi/fcoe/fcoe_ctlr.c:2804: warning: Function parameter or member 
'frport' not described in 'fcoe_ctlr_vlan_parse'
  drivers/scsi/fcoe/fcoe_ctlr.c:2804: warning: Excess function parameter 
'rdata' description in 'fcoe_ctlr_vlan_parse'
  drivers/scsi/fcoe/fcoe_ctlr.c:2900: warning: Excess function parameter 
'min_len' description in 'fcoe_ctlr_vlan_send'
  drivers/scsi/fcoe/fcoe_ctlr.c:2977: warning: Function parameter or member 
'fip' not described in 'fcoe_ctlr_vlan_recv'
  drivers/scsi/fcoe/fcoe_ctlr.c:2977: warning: Function parameter or member 
'skb' not described in 'fcoe_ctlr_vlan_recv'
  drivers/scsi/fcoe/fcoe_ctlr.c:2977: warning: Excess function parameter 
'lport' description in 'fcoe_ctlr_vlan_recv'
  drivers/scsi/fcoe/fcoe_ctlr.c:2977: warning: Excess function parameter 'fp' 
description in 'fcoe_ctlr_vlan_recv'
  drivers/scsi/fcoe/fcoe_ctlr.c:3033: warning: Function parameter or member 
'callback' not described in 'fcoe_ctlr_disc_start'
  drivers/scsi/fcoe/fcoe_ctlr.c:3033: warning: Function parameter or member 
'lport' not described in 'fcoe_ctlr_disc_start'
  drivers/scsi/fcoe/fcoe_ctlr.c:3033: warning: Excess function parameter 'fip' 
description in 'fcoe_ctlr_disc_start'

Cc: Hannes Reinecke <h...@suse.de>
Signed-off-by: Lee Jones <lee.jo...@linaro.org>
---
Changelog:

v2
  - Rename title s/fcoe_ctlr_disc_recv/fcoe_ctlr_disc_start/ while we're at it

  drivers/scsi/fcoe/fcoe_ctlr.c | 28 ++++++++++++++--------------
  1 file changed, 14 insertions(+), 14 deletions(-)

Reviewed-by: Hannes Reinecke <h...@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke            Teamlead Storage & Networking
h...@suse.de                               +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer

Reply via email to