On Tue, Jul 14, 2020 at 4:51 PM Lee Jones <[email protected]> wrote:
>
> Can't see them being used anywhere and the compiler doesn't complain
> that they're missing, so ...
Aren't they needed for automatic module loading in certain configurations?
> Fixes the following W=1 kernel build warning(s):
>
> drivers/cpufreq/acpi-cpufreq.c:1004:36: warning: ‘processor_device_ids’
> defined but not used [-Wunused-const-variable=]
> 997 | static const struct x86_cpu_id acpi_cpufreq_ids[] = {
> | ^~~~~~~~~~~~~~~~
> drivers/cpufreq/acpi-cpufreq.c:997:32: warning: ‘acpi_cpufreq_ids’ defined
> but not used [-Wunused-const-variable=]
> 619 | static const struct acpi_device_id processor_device_ids[] = {
> | ^~~~~~~~~~~~~~~~~~~~
>
> Cc: Andy Grover <[email protected]>
> Cc: Paul Diefenbaugh <[email protected]>
> Cc: Dominik Brodowski <[email protected]>
> Cc: Denis Sadykov <[email protected]>
> Signed-off-by: Lee Jones <[email protected]>
> ---
> drivers/cpufreq/acpi-cpufreq.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
> index d38a693b48e03..fc68f13352695 100644
> --- a/drivers/cpufreq/acpi-cpufreq.c
> +++ b/drivers/cpufreq/acpi-cpufreq.c
> @@ -995,18 +995,4 @@ MODULE_PARM_DESC(acpi_pstate_strict,
> late_initcall(acpi_cpufreq_init);
> module_exit(acpi_cpufreq_exit);
>
> -static const struct x86_cpu_id acpi_cpufreq_ids[] = {
> - X86_MATCH_FEATURE(X86_FEATURE_ACPI, NULL),
> - X86_MATCH_FEATURE(X86_FEATURE_HW_PSTATE, NULL),
> - {}
> -};
> -MODULE_DEVICE_TABLE(x86cpu, acpi_cpufreq_ids);
> -
> -static const struct acpi_device_id processor_device_ids[] = {
> - {ACPI_PROCESSOR_OBJECT_HID, },
> - {ACPI_PROCESSOR_DEVICE_HID, },
> - {},
> -};
> -MODULE_DEVICE_TABLE(acpi, processor_device_ids);
> -
> MODULE_ALIAS("acpi");
> --
> 2.25.1
>
