On Wed, Jul 8, 2020 at 4:04 PM Nick Desaulniers <[email protected]> wrote: > > Two patches, one that removes a BUILD_BUG_ON for a case that is not a > compile time bug (exposed by compiler optimization). > > The second is a general cleanup in the area. > > I decided to leave the BUILD_BUG_ON case first, as I hope it will > simplify being able to backport it to stable, and because I don't think > there's any type promotion+conversion bugs there. > > Though it would be nice to use consistent types widths and signedness, > equality against literal zero is not an issue. > > Jakub Kicinski (1): > bitfield.h: don't compile-time validate _val in FIELD_FIT > > Nick Desaulniers (1): > bitfield.h: split up __BF_FIELD_CHECK macro > > .../netronome/nfp/nfpcore/nfp_nsp_eth.c | 11 ++++---- > include/linux/bitfield.h | 26 +++++++++++++------ > 2 files changed, 24 insertions(+), 13 deletions(-) > > -- > 2.27.0.383.g050319c2ae-goog >
Hey David, when you have a chance, could you please consider picking up this series? -- Thanks, ~Nick Desaulniers
