YueHaibing <yuehaib...@huawei.com> writes: > The stub helpers name should be consistent with prototypes. > > mm_context_add_vas_windows() --> mm_context_add_vas_window() > mm_context_remove_vas_windows() --> mm_context_remove_vas_window() > > Fixes: c420644c0a8f ("powerpc: Use mm_context vas_windows counter to issue > CP_ABORT") > Signed-off-by: YueHaibing <yuehaib...@huawei.com> > --- > arch/powerpc/include/asm/mmu_context.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/include/asm/mmu_context.h > b/arch/powerpc/include/asm/mmu_context.h > index 1a474f6b1992..00fd1d44731a 100644 > --- a/arch/powerpc/include/asm/mmu_context.h > +++ b/arch/powerpc/include/asm/mmu_context.h > @@ -218,8 +218,8 @@ static inline void inc_mm_active_cpus(struct mm_struct > *mm) { } > static inline void dec_mm_active_cpus(struct mm_struct *mm) { } > static inline void mm_context_add_copro(struct mm_struct *mm) { } > static inline void mm_context_remove_copro(struct mm_struct *mm) { } > -static inline void mm_context_add_vas_windows(struct mm_struct *mm) { } > -static inline void mm_context_remove_vas_windows(struct mm_struct *mm) { } > +static inline void mm_context_add_vas_window(struct mm_struct *mm) { } > +static inline void mm_context_remove_vas_window(struct mm_struct *mm) { } > #endif
Both of those functions are only called from 64-bit only code, so the stubs should not be needed at all. Which explains why we haven't seen a build break. So just dropping them would be better IMO. cheers