On Wed, 15 Jul 2020, Viresh Kumar wrote:
> On 15-07-20, 09:26, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/cpufreq/powernv-cpufreq.c:669:6: warning: no previous prototype
> > for ‘gpstate_timer_handler’ [-Wmissing-prototypes]
> > drivers/cpufreq/powernv-cpufreq.c:902:6: warning: no previous prototype
> > for ‘powernv_cpufreq_work_fn’ [-Wmissing-prototypes]
> >
> > Cc: Michael Ellerman <m...@ellerman.id.au>
> > Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org>
> > Cc: Paul Mackerras <pau...@samba.org>
> > Cc: linuxppc-...@lists.ozlabs.org
> > Signed-off-by: Lee Jones <lee.jo...@linaro.org>
> > Acked-by: Viresh Kumar <viresh.ku...@linaro.org>
> > ---
> > drivers/cpufreq/powernv-cpufreq.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/cpufreq/powernv-cpufreq.c
> > b/drivers/cpufreq/powernv-cpufreq.c
> > index 8646eb197cd96..068cc53abe320 100644
> > --- a/drivers/cpufreq/powernv-cpufreq.c
> > +++ b/drivers/cpufreq/powernv-cpufreq.c
> > @@ -666,7 +666,7 @@ static inline void queue_gpstate_timer(struct
> > global_pstate_info *gpstates)
> > * according quadratic equation. Queues a new timer if it is still not
> > equal
> > * to local pstate
> > */
> > -void gpstate_timer_handler(struct timer_list *t)
> > +static void gpstate_timer_handler(struct timer_list *t)
> > {
> > struct global_pstate_info *gpstates = from_timer(gpstates, t, timer);
> > struct cpufreq_policy *policy = gpstates->policy;
> > @@ -899,7 +899,7 @@ static struct notifier_block powernv_cpufreq_reboot_nb
> > = {
> > .notifier_call = powernv_cpufreq_reboot_notifier,
> > };
> >
> > -void powernv_cpufreq_work_fn(struct work_struct *work)
> > +static void powernv_cpufreq_work_fn(struct work_struct *work)
> > {
> > struct chip *chip = container_of(work, struct chip, throttle);
> > struct cpufreq_policy *policy;
>
> Don't you want to drop this patch now ? As you already reviewed the
> other one on the list ?
Yes, please drop/ignore.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
