Hi! On 12/4/19 1:32 PM, Geert Uytterhoeven wrote: >>>> Cc: Will Deacon <[email protected]> >>>> Cc: "Aneesh Kumar K.V" <[email protected]> >>>> Cc: Andrew Morton <[email protected]> >>>> Cc: Nick Piggin <[email protected]> >>>> Cc: Yoshinori Sato <[email protected]> >>>> Cc: Rich Felker <[email protected]> >>>> Signed-off-by: Peter Zijlstra (Intel) <[email protected]> >>> >>> I got remote access to an SH7722-based Migo-R again, which spews a long >>> sequence of BUGs during userspace startup. I've bisected this to commit >>> c5b27a889da92f4a ("sh/tlb: Convert SH to generic mmu_gather"). >> >> Whoopsy.. also, is this really the first time anybody booted an SH >> kernel in over a year ?!? > > Nah, but the v5.4-rc3 I booted recently on qemu -M r2d had > CONFIG_PGTABLE_LEVELS=2, so it didn't show the problem. > >>> Do you have a clue? >> >> Does the below help? > > Unfortunately not. > >> diff --git a/arch/sh/include/asm/pgalloc.h b/arch/sh/include/asm/pgalloc.h >> index 22d968bfe9bb..73a2c00de6c5 100644 >> --- a/arch/sh/include/asm/pgalloc.h >> +++ b/arch/sh/include/asm/pgalloc.h >> @@ -36,9 +36,8 @@ do { \ >> #if CONFIG_PGTABLE_LEVELS > 2 >> #define __pmd_free_tlb(tlb, pmdp, addr) \ >> do { \ >> - struct page *page = virt_to_page(pmdp); \ >> - pgtable_pmd_page_dtor(page); \ >> - tlb_remove_page((tlb), page); \ >> + pgtable_pmd_page_dtor(pmdp); \ > > expected ‘struct page *’ but argument is of type ‘pmd_t * {aka struct > <anonymous> *}’ > >> + tlb_remove_page((tlb), (pmdp)); \ > > likewise > >> } while (0); >> #endif
Any chance we can have another go at this? The original change commit c5b27a889da92f4a969d61df77bd4f79ffce57c9 (refs/bisect/bad) Author: Peter Zijlstra <[email protected]> Date: Tue Sep 4 14:45:04 2018 +0200 sh/tlb: Convert SH to generic mmu_gather Generic mmu_gather provides everything SH needs (range tracking and cache coherency). breaks systemd for me on my SH-7785LCR [1]. Adrian > [1] https://marc.info/?l=linux-kernel&m=159479951822677&w=2 Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - [email protected] `. `' Freie Universitaet Berlin - [email protected] `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
