From: Yongqiang Liu <liuyongqian...@huawei.com>

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by: Yongqiang Liu <liuyongqian...@huawei.com>
---
 drivers/memory/emif.c               | 22 ++--------------------
 drivers/memory/tegra/tegra124-emc.c | 14 +-------------
 2 files changed, 3 insertions(+), 33 deletions(-)

diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c
index 58a82eea5..aab8ddad7 100644
--- a/drivers/memory/emif.c
+++ b/drivers/memory/emif.c
@@ -131,16 +131,7 @@ static int emif_regdump_show(struct seq_file *s, void 
*unused)
        return 0;
 }
 
-static int emif_regdump_open(struct inode *inode, struct file *file)
-{
-       return single_open(file, emif_regdump_show, inode->i_private);
-}
-
-static const struct file_operations emif_regdump_fops = {
-       .open                   = emif_regdump_open,
-       .read_iter                      = seq_read_iter,
-       .release                = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(emif_regdump);
 
 static int emif_mr4_show(struct seq_file *s, void *unused)
 {
@@ -150,16 +141,7 @@ static int emif_mr4_show(struct seq_file *s, void *unused)
        return 0;
 }
 
-static int emif_mr4_open(struct inode *inode, struct file *file)
-{
-       return single_open(file, emif_mr4_show, inode->i_private);
-}
-
-static const struct file_operations emif_mr4_fops = {
-       .open                   = emif_mr4_open,
-       .read_iter                      = seq_read_iter,
-       .release                = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(emif_mr4);
 
 static int __init_or_module emif_debugfs_init(struct emif_data *emif)
 {
diff --git a/drivers/memory/tegra/tegra124-emc.c 
b/drivers/memory/tegra/tegra124-emc.c
index 23c44429e..16628df1b 100644
--- a/drivers/memory/tegra/tegra124-emc.c
+++ b/drivers/memory/tegra/tegra124-emc.c
@@ -1059,19 +1059,7 @@ static int tegra_emc_debug_available_rates_show(struct 
seq_file *s,
        return 0;
 }
 
-static int tegra_emc_debug_available_rates_open(struct inode *inode,
-                                               struct file *file)
-{
-       return single_open(file, tegra_emc_debug_available_rates_show,
-                          inode->i_private);
-}
-
-static const struct file_operations tegra_emc_debug_available_rates_fops = {
-       .open = tegra_emc_debug_available_rates_open,
-       .read_iter = seq_read_iter,
-       .llseek = seq_lseek,
-       .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(tegra_emc_debug_available_rates);
 
 static int tegra_emc_debug_min_rate_get(void *data, u64 *rate)
 {
-- 
2.17.1

Reply via email to