Re: [PATCH] ASoC: meson: add the missed kfree() for axg_card_add_tdm_loopback

[Jerome Brunet]

On Thu 16 Jul 2020 at 15:25, Jing Xiangfeng <jingxiangf...@huawei.com> wrote:

> axg_card_add_tdm_loopback() misses to call kfree() in an error path. Add
> the missed function call to fix it.
>
> Fixes: c84836d7f650 ("ASoC: meson: axg-card: use modern dai_link style")
> Signed-off-by: Jing Xiangfeng <jingxiangf...@huawei.com>

Thanks for fixing this.
Maybe it would be better to use the devm_ variant for the name instead ?

> ---
>  sound/soc/meson/axg-card.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/meson/axg-card.c b/sound/soc/meson/axg-card.c
> index 89f7f64747cd..6eac22ba8b99 100644
> --- a/sound/soc/meson/axg-card.c
> +++ b/sound/soc/meson/axg-card.c
> @@ -121,8 +121,10 @@ static int axg_card_add_tdm_loopback(struct snd_soc_card 
> *card,
>               return -ENOMEM;
>  
>       dlc = devm_kzalloc(card->dev, 2 * sizeof(*dlc), GFP_KERNEL);
> -     if (!dlc)
> +     if (!dlc) {
> +             kfree(lb->name);
>               return -ENOMEM;
> +     }
>  
>       lb->cpus = &dlc[0];
>       lb->codecs = &dlc[1];