On Thu, Jul 16, 2020 at 09:47:10PM +0800, Bixuan Cui wrote: > Fix the warning: [-Werror=-Wframe-larger-than=] > > drivers/usb/misc/usbtest.c: In function 'test_queue': > drivers/usb/misc/usbtest.c:2148:1: > warning: the frame size of 1232 bytes is larger than 1024 bytes > > Reported-by: kbuild test robot <l...@intel.com> > Signed-off-by: Bixuan Cui <cuibix...@huawei.com> > --- > drivers/usb/misc/usbtest.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c > index 8b220d56647b..a9b40953d6bc 100644 > --- a/drivers/usb/misc/usbtest.c > +++ b/drivers/usb/misc/usbtest.c > @@ -2043,7 +2043,7 @@ test_queue(struct usbtest_dev *dev, struct > usbtest_param_32 *param, > unsigned i; > unsigned long packets = 0; > int status = 0; > - struct urb *urbs[MAX_SGLEN]; > + struct urb **urbs; > > if (!param->sglen || param->iterations > UINT_MAX / param->sglen) > return -EINVAL; > @@ -2051,6 +2051,10 @@ test_queue(struct usbtest_dev *dev, struct > usbtest_param_32 *param, > if (param->sglen > MAX_SGLEN) > return -EINVAL; > > + urbs = kcalloc(MAX_SGLEN, sizeof(*urbs), GFP_KERNEL);
Since you know at runtime how many URBs will be needed, why not use that information? Change MAX_SGLEN to param->sglen. Aside from that, Acked-by: Alan Stern <st...@rowland.harvard.edu> Alan Stern
